linux-kernel - Re: [PATCH v3 00/16] Add support for AXP192 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7bYbROHIFQUbzWDNUadQUEIYRAVaP5V5@localhost>
Date:   Sun, 19 Jun 2022 15:54:41 +0100
From:   Aidan MacDonald <aidanmacdonald.0x0@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "brgl@...ev.pl" <brgl@...ev.pl>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "wens@...e.org" <wens@...e.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "sre@...nel.org" <sre@...nel.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "quic_gurus@...cinc.com" <quic_gurus@...cinc.com>,
        "sebastian.reichel@...labora.com" <sebastian.reichel@...labora.com>,
        "michael@...le.cc" <michael@...le.cc>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v3 00/16] Add support for AXP192 PMIC


Andy Shevchenko <andy.shevchenko@...il.com> writes:

> On Sun, Jun 19, 2022 at 1:08 PM Jonathan Cameron <jic23@...nel.org> wrote:
>> On Sun, 19 Jun 2022 00:43:07 +0200
>> Andy Shevchenko <andy.shevchenko@...il.com> wrote:
>> > On Saturday, June 18, 2022, Aidan MacDonald <aidanmacdonald.0x0@...il.com>
>> > wrote:
>> >
>> > > Changes in v3:
>> > >
>> > > * Update pinctrl driver to address Andy Shevchenko's review comments
>> > >   from v1, and fix a few other
>> >
>> > I believe I gave more comments than just against pin control driver. Even
>> > though, some comments are still not addressed in the series, including pin
>> > control. Am I mistaken?
>>
>> Hi Andy,
>>
>> Maybe, it's a question of clarity/misunderstanding? You had some 'global' comments
>> at the end of the pinctrl review. Perhaps not clear enough you meant
>> they should apply to the rest of the patch series (and more generally to
>> the driver being modified I think).
>
> Yeah, I think that is.
> I don't remember if we have somewhere a documentation on how to
> respond to the review comments, in which the point of addressing
> comment everywhere in the series, and not only in the place(s) where
> it was given.

That's exactly it, I was only looking at the pinctrl patch since that's
the one you replied to, and didn't think to check the other patches for
similar cases even though that's obvious in retrospect. Sorry for any
confusion.