linux-kernel - Re: [PATCH v3 11/16] iio: adc: axp20x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9VAa62XhSlCMAJF7vdE7bHGSg95FKyr6@localhost>
Date:   Sun, 19 Jun 2022 16:11:51 +0100
From:   Aidan MacDonald <aidanmacdonald.0x0@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     linus.walleij@...aro.org, brgl@...ev.pl, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, wens@...e.org,
        lee.jones@...aro.org, sre@...nel.org, broonie@...nel.org,
        gregkh@...uxfoundation.org, lgirdwood@...il.com, lars@...afoo.de,
        rafael@...nel.org, quic_gurus@...cinc.com,
        sebastian.reichel@...labora.com, andy.shevchenko@...il.com,
        michael@...le.cc, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 11/16] iio: adc: axp20x_adc: Add support for AXP192


Jonathan Cameron <jic23@...nel.org> writes:

> On Sat, 18 Jun 2022 22:40:04 +0100
> Aidan MacDonald <aidanmacdonald.0x0@...il.com> wrote:
>
>> The AXP192 is identical to the AXP20x, except for the addition of
>> two more GPIO ADC channels.
>> 
>> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@...il.com>
> Hi Aidan,
>
> Looking at this again, I'd have a slight preference for doing the switch to
> adc_en2_mask as a precursor patch.

I might as well, it's a bit cleaner that way.

>
> Still, not a big thing (and I should have raised it earlier!) so up to you.
> Either way
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>
> Thanks,
>
> Jonathan