linux-kernel - Re: [PATCH v2] mfd: tc6393xb: Make disable callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 Jun 2022 21:35:26 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     kernel test robot <lkp@...el.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>, kernel@...gutronix.de,
        kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] mfd: tc6393xb: Make disable callback return void

Hello,

On Mon, Jun 20, 2022 at 02:20:57AM +0800, kernel test robot wrote:
> Hi "Uwe,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on f2906aa863381afb0015a9eb7fefad885d4e5a56]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Uwe-Kleine-K-nig/mfd-tc6393xb-Make-disable-callback-return-void/20220619-162855
> base:   f2906aa863381afb0015a9eb7fefad885d4e5a56
> config: arm-pxa_defconfig (https://download.01.org/0day-ci/archive/20220620/202206200102.cUbYiyCL-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/e2b80b7c107cdbbff99189431a614f791435ebfd
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Uwe-Kleine-K-nig/mfd-tc6393xb-Make-disable-callback-return-void/20220619-162855
>         git checkout e2b80b7c107cdbbff99189431a614f791435ebfd
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>    arch/arm/mach-pxa/eseries.c:47:13: warning: no previous prototype for 'eseries_fixup' [-Wmissing-prototypes]
>       47 | void __init eseries_fixup(struct tag *tags, char **cmdline)
>          |             ^~~~~~~~~~~~~
>    arch/arm/mach-pxa/eseries.c:76:5: warning: no previous prototype for 'eseries_tmio_enable' [-Wmissing-prototypes]
>       76 | int eseries_tmio_enable(struct platform_device *dev)
>          |     ^~~~~~~~~~~~~~~~~~~
>    arch/arm/mach-pxa/eseries.c:89:6: warning: no previous prototype for 'eseries_tmio_disable' [-Wmissing-prototypes]
>       89 | void eseries_tmio_disable(struct platform_device *dev)
>          |      ^~~~~~~~~~~~~~~~~~~~
>    arch/arm/mach-pxa/eseries.c:95:5: warning: no previous prototype for 'eseries_tmio_suspend' [-Wmissing-prototypes]
>       95 | int eseries_tmio_suspend(struct platform_device *dev)
>          |     ^~~~~~~~~~~~~~~~~~~~
>    arch/arm/mach-pxa/eseries.c:101:5: warning: no previous prototype for 'eseries_tmio_resume' [-Wmissing-prototypes]
>      101 | int eseries_tmio_resume(struct platform_device *dev)
>          |     ^~~~~~~~~~~~~~~~~~~
>    arch/arm/mach-pxa/eseries.c:108:6: warning: no previous prototype for 'eseries_get_tmio_gpios' [-Wmissing-prototypes]
>      108 | void eseries_get_tmio_gpios(void)
>          |      ^~~~~~~~~~~~~~~~~~~~~~
> >> arch/arm/mach-pxa/eseries.c:141:21: error: initialization of 'int (*)(struct platform_device *)' from incompatible pointer type 'void (*)(struct platform_device *)' [-Werror=incompatible-pointer-types]
>      141 |         .disable  = &eseries_tmio_disable,
>          |                     ^
>    arch/arm/mach-pxa/eseries.c:141:21: note: (near initialization for 'e330_tc6387xb_info.disable')
>    cc1: some warnings being treated as errors
> 
> 
> vim +141 arch/arm/mach-pxa/eseries.c
> 
> e478fe4cd50b86 Eric Miao 2010-06-20  138  
> e478fe4cd50b86 Eric Miao 2010-06-20  139  static struct tc6387xb_platform_data e330_tc6387xb_info = {
> e478fe4cd50b86 Eric Miao 2010-06-20  140  	.enable   = &eseries_tmio_enable,
> e478fe4cd50b86 Eric Miao 2010-06-20 @141  	.disable  = &eseries_tmio_disable,
> e478fe4cd50b86 Eric Miao 2010-06-20  142  	.suspend  = &eseries_tmio_suspend,
> e478fe4cd50b86 Eric Miao 2010-06-20  143  	.resume   = &eseries_tmio_resume,
> e478fe4cd50b86 Eric Miao 2010-06-20  144  };
> e478fe4cd50b86 Eric Miao 2010-06-20  145  

Oh, indeed. I forgot that this patch depends on

	https://lore.kernel.org/all/20220530192430.2108217-4-u.kleine-koenig@pengutronix.de

that Lee already claimed to have applied. This patch removes line 141
and the problem is gone.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)