linux-kernel - Re: [PATCH] powerpc/interrupt: Put braces around empty body in an 'if' statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9341e518-ba3a-956f-65bf-1a824fa0c77b@csgroup.eu>
Date:   Sun, 19 Jun 2022 06:40:22 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Souptick Joarder <jrdr.linux@...il.com>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "paulus@...ba.org" <paulus@...ba.org>,
        "npiggin@...il.com" <npiggin@...il.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mark.rutland@....com" <mark.rutland@....com>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] powerpc/interrupt: Put braces around empty body in an
 'if' statement



Le 19/06/2022 à 05:11, Souptick Joarder a écrit :
> From: "Souptick Joarder (HPE)" <jrdr.linux@...il.com>
> 
> Kernel test robot throws warning ->
> 
> arch/powerpc/kernel/interrupt.c:
> In function 'interrupt_exit_kernel_prepare':
> 
>>> arch/powerpc/kernel/interrupt.c:542:55: warning: suggest
> braces around empty body in an 'if' statement [-Wempty-body]
>       542 |                 CT_WARN_ON(ct_state() == CONTEXT_USER);
> 
> Fix it by adding braces.

There must be no braces for single 'if' statement , see 
https://docs.kernel.org/process/coding-style.html#placing-braces-and-spaces

The problem is likely that CT_WARN_ON() is empty in some CONFIGs.
You have to fix it, for instance by changing it to a "do { } while (0)"

> 
> Reported-by: Kernel test robot <lkp@...el.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@...il.com>
> ---
>   arch/powerpc/kernel/interrupt.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c
> index 784ea3289c84..b8a918bab48f 100644
> --- a/arch/powerpc/kernel/interrupt.c
> +++ b/arch/powerpc/kernel/interrupt.c
> @@ -538,8 +538,9 @@ notrace unsigned long interrupt_exit_kernel_prepare(struct pt_regs *regs)
>           * CT_WARN_ON comes here via program_check_exception,
>           * so avoid recursion.
>           */
> -       if (TRAP(regs) != INTERRUPT_PROGRAM)
> +       if (TRAP(regs) != INTERRUPT_PROGRAM) {
>                  CT_WARN_ON(ct_state() == CONTEXT_USER);
> +       }
> 
>          kuap = kuap_get_and_assert_locked();
> 
> --
> 2.25.1
>