linux-kernel - Re: [PATCH] USB: serial: use kmemdup instead of kmalloc + memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrBx2eQYwiGcDC8m@hovoldconsulting.com>
Date:   Mon, 20 Jun 2022 15:10:49 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Slark Xiao <slark_xiao@....com>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: use kmemdup instead of kmalloc + memcpy

On Mon, Jun 20, 2022 at 06:59:39PM +0800, Slark Xiao wrote:
> For code neat purpose, we can use kmemdup to replace
> kmalloc + memcpy.
> 
> Signed-off-by: Slark Xiao <slark_xiao@....com>
> ---
>  drivers/usb/serial/opticon.c | 4 +---
>  drivers/usb/serial/sierra.c  | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/opticon.c
> index aed28c35caff..bca6766a63e6 100644
> --- a/drivers/usb/serial/opticon.c
> +++ b/drivers/usb/serial/opticon.c
> @@ -208,7 +208,7 @@ static int opticon_write(struct tty_struct *tty, struct usb_serial_port *port,
>  	priv->outstanding_bytes += count;
>  	spin_unlock_irqrestore(&priv->lock, flags);
>  
> -	buffer = kmalloc(count, GFP_ATOMIC);
> +	buffer = kmemdup(buf, count, GFP_ATOMIC);
>  	if (!buffer)
>  		goto error_no_buffer;
>  
> @@ -216,8 +216,6 @@ static int opticon_write(struct tty_struct *tty, struct usb_serial_port *port,
>  	if (!urb)
>  		goto error_no_urb;
>  
> -	memcpy(buffer, buf, count);
> -
>  	usb_serial_debug_data(&port->dev, __func__, count, buffer);
>  
>  	/* The connected devices do not have a bulk write endpoint,

Looks like we have the same pattern also in garmin_write_bulk(). Care to
include that one as well?

Johan