linux-kernel - Re: [PATCH 3/4] ASoC: wm8904: extend device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR08MB437675AD04D20721769B08A3FFB09@AM6PR08MB4376.eurprd08.prod.outlook.com>
Date:   Mon, 20 Jun 2022 14:32:17 +0000
From:   Pierluigi Passaro <pierluigi.p@...iscite.com>
To:     Mark Brown <broonie@...nel.org>,
        Alifer Willians de Moraes <alifer.m@...iscite.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Eran Matityahu <eran.m@...iscite.com>,
        "festevam@...il.com" <festevam@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "nicoleotsuka@...il.com" <nicoleotsuka@...il.com>,
        "patches@...nsource.cirrus.com" <patches@...nsource.cirrus.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shengjiu.wang@...il.com" <shengjiu.wang@...il.com>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "Xiubo.Lee@...il.com" <Xiubo.Lee@...il.com>
Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support

Hi All,

> > +  - num-drc-cfgs: Number of available DRC modes from drc-cfg-regs property
> > +
> > +  - drc-cfg-regs: Default registers value for R40/41/42/43 (DRC)
> > +    The list must be (4 x num-drc-cfgs) entries long.
> > +    If absent or incomplete, DRC is disabled.
> 
> What is the purpose of having num-drc-cfgs?  We can tell how large
> drc-cfg-regs is so it just seems redundant.

Can you please point me to any reference implementation doing this ?

> > +  - num-retune-mobile-cfgs: Number of retune modes available from
> > +    retune-mobile-cfg-regs property
> 
> Same here.

Thanks
Best Regards
Pier