linux-kernel - Re: [PATCH 3/4] ASoC: wm8904: extend device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR08MB43761F7E94081064E8FA478FFFB09@AM6PR08MB4376.eurprd08.prod.outlook.com>
Date:   Mon, 20 Jun 2022 14:39:55 +0000
From:   Pierluigi Passaro <pierluigi.p@...iscite.com>
To:     Rob Herring <robh@...nel.org>,
        Alifer Willians de Moraes <alifer.m@...iscite.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Eran Matityahu <eran.m@...iscite.com>,
        "festevam@...il.com" <festevam@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "nicoleotsuka@...il.com" <nicoleotsuka@...il.com>,
        "patches@...nsource.cirrus.com" <patches@...nsource.cirrus.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "shengjiu.wang@...il.com" <shengjiu.wang@...il.com>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "Xiubo.Lee@...il.com" <Xiubo.Lee@...il.com>
Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support

> > The platform_data structure is not populated when using device trees.
> > This patch adds optional dts properties to allow populating it:
> > - gpio-cfg
> > - mic-cfg
> > - num-drc-cfgs
> > - drc-cfg-regs
> > - drc-cfg-names
> > - num-retune-mobile-cfgs
> > - retune-mobile-cfg-regs
> > - retune-mobile-cfg-names
> > - retune-mobile-cfg-rates
> 
> If you want to add all this, convert to DT schema first. 
> They all need vendor prefixes for starters.

Beyond adding the vendor prefix, can you please add details or provide any reference about "convert to DT schema" ?

> > 
> > Signed-off-by: Pierluigi Passaro <pierluigi.p@...iscite.com>
> > Signed-off-by: Alifer Moraes <alifer.m@...iscite.com>
> > ---
> >  .../devicetree/bindings/sound/wm8904.txt      |  53 ++++++++
> >  sound/soc/codecs/wm8904.c                     | 113 +++++++++++++++++-
> 
> Binding changes go in their own patches.

Do you mean that C code and TXT documentation should be provided as separated patches ?

Thanks
Best Regards
Pier