linux-kernel - Re: [PATCH 4/4] ASoC: wm8904: add DMIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR08MB43760A5F78137DAE68FE99C7FFB09@AM6PR08MB4376.eurprd08.prod.outlook.com>
Date:   Mon, 20 Jun 2022 17:52:43 +0000
From:   Pierluigi Passaro <pierluigi.p@...iscite.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Alifer Willians de Moraes <alifer.m@...iscite.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Eran Matityahu <eran.m@...iscite.com>,
        "festevam@...il.com" <festevam@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "nicoleotsuka@...il.com" <nicoleotsuka@...il.com>,
        "patches@...nsource.cirrus.com" <patches@...nsource.cirrus.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shengjiu.wang@...il.com" <shengjiu.wang@...il.com>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "Xiubo.Lee@...il.com" <Xiubo.Lee@...il.com>
Subject: Re: [PATCH 4/4] ASoC: wm8904: add DMIC support

> > Just for my understanding, are you suggesting to set a device tree
> > property to force a fixed behavior in the driver ?

> Yes.

Why should we use a fixed behavior ?

> > WM8904 allows using both a DMIC and LINEIN, switching between one or
> > the other and this is how we currently use it.
> > Why the user should not be allowed to switch between DMIC and LINEIN ?

> The device shares pins between the line inputs and the DMIC inputs so at
> least some of the configuration is going to be determinted at system
> design time, that will fix the usable values of at least one of the
> controls which ought to be reflected in the runtime behaviour.

In our design we use:
- pin 1: DMIC_CLK
- pin 24: LINEIN2R
- pin 26: LINEIN2L
- pin 27: DMIC_DATA
we have no pins shared among DMIC and LINEIN.
We have several customer switching between DMIC and LINEIN at runtime.

> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns.  Doing this makes your messages much
> easier to read and reply to.

I beg your pardon: it should be fixed now.