linux-kernel - Re: [PATCH] fbdev: simplefb: Check before clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f7e75426-035b-bf0a-b565-bc816b4eeb23@gmx.de>
Date:   Mon, 20 Jun 2022 20:25:09 +0200
From:   Helge Deller <deller@....de>
To:     Hans de Goede <hdegoede@...hat.com>, Yihao Han <hanyihao@...o.com>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev: simplefb: Check before clk_put() not needed

On 6/2/22 12:50, Hans de Goede wrote:
> Hi,
>
> On 6/2/22 11:42, Yihao Han wrote:
>> clk_put() already checks the clk ptr using !clk and IS_ERR()
>> so there is no need to check it again before calling it.
>>
>> Signed-off-by: Yihao Han <hanyihao@...o.com>
>> ---
>>  drivers/video/fbdev/simplefb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
>> index 2c198561c338..f96ce8801be4 100644
>> --- a/drivers/video/fbdev/simplefb.c
>> +++ b/drivers/video/fbdev/simplefb.c
>> @@ -237,8 +237,7 @@ static int simplefb_clocks_get(struct simplefb_par *par,
>>  		if (IS_ERR(clock)) {
>>  			if (PTR_ERR(clock) == -EPROBE_DEFER) {
>>  				while (--i >= 0) {
>> -					if (par->clks[i])
>> -						clk_put(par->clks[i]);
>> +					clk_put(par->clks[i]);
>>  				}
>>  				kfree(par->clks);
>>  				return -EPROBE_DEFER;
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>

applied to fbdev tree.

Thanks!
Helge