linux-kernel - Re: [PATCH] arm64: rockchip: rk3399-roc-pc: prevent fusb302 powering off the board during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YrDQDLOXQKtPVgzU@Red>
Date:   Mon, 20 Jun 2022 21:52:44 +0200
From:   LABBE Corentin <clabbe@...libre.com>
To:     heiko@...ech.de, krzysztof.kozlowski+dt@...aro.org,
        robh+dt@...nel.org, m.reichl@...etechno.de
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        stable@...nel.org
Subject: Re: [PATCH] arm64: rockchip: rk3399-roc-pc: prevent fusb302 powering
 off the board during boot

Le Mon, Jun 20, 2022 at 11:04:07AM +0000, Corentin Labbe a écrit :
> The rk3399-roc-pc never finish booting because it is powered off when probing
> fusb302.
> 
> The type c port is disabled because not present in DT as can seen in dmesg:
> OF: graph: no port node found in /i2c@...d0000/usb-typec@22
> 
> So adding the port in DT (as needed by the device tree schema of
> fusb302), permits the board to survive and finish booting.
> 
> CC: stable@...nel.org # 5.10+
> Fixes: 8bb878cf20ae ("arm64: dts: rockchip: add support for ROC-RK3399-PC board")
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
> This patch is tested on 5.10.123, 5.15.48 and next-20220614
> 

Please ignore this for now, it fixes the issue but
[   31.653778] typec_fusb302 7-0022: cannot register tcpm port, ret=-22
[   31.659415] typec_fusb302: probe of 7-0022 failed with error -22

So while having a board which boot fine is better, having everything well probed will be better.

For fixing the probe error, adding the following is sufficiant:
@@ -558,6 +559,9 @@ connector {
                        data-role = "host";
                        label = "USB-C";
                        power-role = "dual";
+                       op-sink-microwatt = <1000000>;
+                       sink-pdos = <PDO_FIXED(5000, 2500, PDO_FIXED_USB_COMM)>;
+                       source-pdos = <PDO_FIXED(5000, 1400, PDO_FIXED_USB_COMM)>;
 
                        ports {
                                #address-cells = <1>;
But this bring the initial issue, the board is still dont booting...