linux-kernel - Re: [PATCH 0/2] get rid of useless header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Jun 2022 15:02:10 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Nam Cao <namcaov@...il.com>, gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        phil@...lpotter.co.uk, paskripkin@...il.com
Subject: Re: [PATCH 0/2] get rid of useless header file

On 6/20/22 12:19, Nam Cao wrote:
> The stuffs in basic_types.h are either not used, or already defined in
> the kernel. Get rid of it.
> 
> Nam Cao (2):
>    staging: r8188eu: replace N_BYTE_ALIGMENT with ALIGN
>    staging: r8188eu: remove basic_types.h
> 
>   drivers/staging/r8188eu/core/rtw_recv.c       |  2 +-
>   drivers/staging/r8188eu/core/rtw_xmit.c       |  6 +++---
>   drivers/staging/r8188eu/hal/rtl8188eu_recv.c  |  2 +-
>   drivers/staging/r8188eu/include/basic_types.h | 19 -------------------
>   .../staging/r8188eu/include/osdep_service.h   |  1 -
>   drivers/staging/r8188eu/os_dep/xmit_linux.c   |  2 +-
>   6 files changed, 6 insertions(+), 26 deletions(-)
>   delete mode 100644 drivers/staging/r8188eu/include/basic_types.h
> 

For future patch sets, please include the "staging: r8188eu:" part of the 
subject of the cover letter. It makes it easier to sort out the rest of the 
patches; however,it is not necessary to resubmit this one.

The two patchesw are fine.

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Thanks,

Larry