lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jun 2022 21:06:10 +0100 From: Aidan MacDonald <aidanmacdonald.0x0@...il.com> To: broonie@...nel.org Cc: agross@...nel.org, bjorn.andersson@...aro.org, srinivas.kandagatla@...aro.org, bgoswami@...eaurora.org, gregkh@...uxfoundation.org, rafael@...nel.org, cw00.choi@...sung.com, krzysztof.kozlowski@...aro.org, b.zolnierkie@...sung.com, myungjoo.ham@...sung.com, michael@...le.cc, linus.walleij@...aro.org, brgl@...ev.pl, tglx@...utronix.de, maz@...nel.org, lee.jones@...aro.org, mani@...nel.org, cristian.ciocaltea@...il.com, wens@...e.org, tharvey@...eworks.com, rjones@...eworks.com, mazziesaccount@...il.com, orsonzhai@...il.com, baolin.wang7@...il.com, zhang.lyra@...il.com, jernej.skrabec@...il.com, samuel@...lland.org, lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, linux-actions@...ts.infradead.org, linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev, alsa-devel@...a-project.org Subject: [PATCH 15/49] regmap-irq: Change the behavior of mask_writeonly No drivers currently use mask_writeonly, and in its current form it seems a bit misleading. When set, mask registers will be updated with regmap_write_bits() instead of regmap_update_bits(), but regmap_write_bits() still does a read-modify-write under the hood. It's not a write-only operation. Performing a simple regmap_write() is probably more useful, since it can be used for chips that have separate set & clear registers for controlling mask bits. Such registers are normally volatile and read as 0, so avoiding a register read minimizes bus traffic. Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@...il.com> --- drivers/base/regmap/regmap-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c index dd22d13c54c8..4c0d7f7aa544 100644 --- a/drivers/base/regmap/regmap-irq.c +++ b/drivers/base/regmap/regmap-irq.c @@ -84,7 +84,7 @@ static int regmap_irq_update_bits(struct regmap_irq_chip_data *d, unsigned int val) { if (d->chip->mask_writeonly) - return regmap_write_bits(d->map, reg, mask, val); + return regmap_write(d->map, reg, val & mask); else return regmap_update_bits(d->map, reg, mask, val); } -- 2.35.1
Powered by blists - more mailing lists