linux-kernel - Re: [kbuild-all] Re: [PATCH] MAINTAINERS: Update DW 8250 UART maintainership

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e87a53b4-6fd1-f4a5-76c-37d8e61bf087@linux.intel.com>
Date:   Mon, 20 Jun 2022 09:12:06 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     "Chen, Rong A" <rong.a.chen@...el.com>
cc:     Joe Perches <joe@...ches.com>, kernel test robot <lkp@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        kbuild-all@...ts.01.org, Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [kbuild-all] Re: [PATCH] MAINTAINERS: Update DW 8250 UART
 maintainership

On Mon, 20 Jun 2022, Chen, Rong A wrote:
> On 6/18/2022 4:17 AM, Joe Perches wrote:
> > On Sat, 2022-06-18 at 04:09 +0800, kernel test robot wrote:
> > > Hi "Ilpo,
> > > 
> > > Thank you for the patch! Yet something to improve:
> > > 
> > > [auto build test ERROR on linus/master]
> > > [also build test ERROR on v5.19-rc2 next-20220617]
> > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > And when submitting patch, we suggest to use '--base' as documented in
> > > https://git-scm.com/docs/git-format-patch]
> > > 
> > > url:
> > > https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/MAINTAINERS-Update-DW-8250-UART-maintainership/20220617-174145
> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > > 47700948a4abb4a5ae13ef943ff682a7f327547a
> > > reproduce: make htmldocs
> > > 
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <lkp@...el.com>
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > > > > 'utf-8' codec can't decode byte 0xe4 in position 1396: invalid
> > > > > continuation byte
> > 
> > ?
> > 
> > false positive?

This is correctly identified problem, however, the problem is lkp's end.
It seemingly fails to handle non-UTF8 encoded emails correctly and just 
goes to assume the input is UTF8 encoded (w/o checking the Content-Type 
header).

> I tried to apply the patch, and I can reproduce the error by 'make htmldocs':
> 
> $ wget -q -O -
> https://lore.kernel.org/lkml/be58b398-71ff-7c12-1bf1-a09181d9c80@linux.intel.com/raw
> | git apply -v
> $ git --no-pager diff
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f52543aedd61e..3d64756814f09 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19247,8 +19247,9 @@ F:
> Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
>  F:     drivers/gpio/gpio-creg-snps.c
> 
>  SYNOPSYS DESIGNWARE 8250 UART DRIVER
> +M:     Ilpo Jrvinen <ilpo.jarvinen@...ux.intel.com>
>  R:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> -S:     Maintained
> +S:     Supported
>  F:     drivers/tty/serial/8250/8250_dw.c
>  F:     drivers/tty/serial/8250/8250_dwlib.*
>  F:     drivers/tty/serial/8250/8250_lpss.c
> 
> It seems the special character 'ä' in name 'Ilpo Järvinen' was parsed wrongly.

The original file was UTF-8 (0xc3 0xa4). The email is correctly encoded 
ISO 8859-15 as can be see e.g. by downloading this (with a single 0xe4 
char):
  https://marc.info/?l=linux-kernel&m=165545870203513&q=raw

When saving patch/exporting email, MUA/exporter should do ISO 8859-15 -> 
UTF-8 conversion. If I export email I sent, I get it back to UTF-8 just 
fine (as per the locale I've in use).

Just in case, I've attached the original patch file.

I thought git's toolchain these days handles these things fine but 
it seems not.


-- 
 i.
View attachment "maint.patch" of type "text/x-diff" (944 bytes)