linux-kernel - Re: [PATCH v2] sh: Convert nommu io{re,un}map() to static inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220620070606.GA11361@lst.de>
Date:   Mon, 20 Jun 2022 09:06:06 +0200
From:   Christoph Hellwig <hch@....de>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v2] sh: Convert nommu io{re,un}map() to static inline
 functions

On Mon, Jun 20, 2022 at 09:01:43AM +0200, Geert Uytterhoeven wrote:
> Recently, nommu iounmap() was converted from a static inline function to
> a macro again, basically reverting commit 4580ba4ad2e6b8dd ("sh: Convert
> iounmap() macros to inline functions").  With -Werror, this leads to
> build failures like:

Stupid question:  Is there any reason sh-nommu can't just use the
generic nommu ioremap from asm-generic/io.h?

Then again how long it takes to to fix any sh bugs I'm still wondering
if we shouldn't just drop sh entirely given how much of a drag it is
on everyone.