linux-kernel - Re: [PATCH 1/5] scsi: core: Remove reserved request time-out handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b033027d-2600-0c7a-a74a-133bda610f2c@huawei.com>
Date:   Mon, 20 Jun 2022 08:37:25 +0100
From:   John Garry <john.garry@...wei.com>
To:     Christoph Hellwig <hch@....de>
CC:     <axboe@...nel.dk>, <damien.lemoal@...nsource.wdc.com>,
        <bvanassche@....org>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <hare@...e.de>, <satishkh@...co.com>,
        <sebaddel@...co.com>, <kartilak@...co.com>,
        <linux-rdma@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
        <linux-nvme@...ts.infradead.org>, <linux-s390@...r.kernel.org>,
        <linux-scsi@...r.kernel.org>, <mpi3mr-linuxdrv.pdl@...adcom.com>,
        <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <nbd@...er.debian.org>
Subject: Re: [PATCH 1/5] scsi: core: Remove reserved request time-out handling

On 20/06/2022 06:58, Christoph Hellwig wrote:
> On Fri, Jun 17, 2022 at 06:55:16PM +0800, John Garry wrote:
>> The SCSI code does not currently support reserved commands. As such,
>> requests which time-out would never be reserved, and scsi_timeout()
>> 'reserved' arg should never be set.
>>
>> Remove handling for reserved requests and drop wrapper scsi_timeout() as
>> it now just calls scsi_times_out() always.
> 
> Please rename scsi_times_out to scsi_timeout so it still matches the
> method name.
>

ok, note that some code comments and Documentation reference 
scsi_times_out() so I will need to fix them up also.


> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 
> .

Cheers,
John