linux-kernel - Re: [PATCH RFC 3/3] vdpa/mlx5: Disable VLAN support to support live migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEsKzS==HQC8C-Pf+7T7rcsg0cHjXEw2tmhFrjjUCQy6UA@mail.gmail.com>
Date:   Mon, 20 Jun 2022 17:25:28 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Eugenio Perez Martin <eperezma@...hat.com>
Cc:     Eli Cohen <elic@...dia.com>, mst <mst@...hat.com>,
        virtualization <virtualization@...ts.linux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Si-Wei Liu <si-wei.liu@...cle.com>,
        Parav Pandit <parav@...dia.com>
Subject: Re: [PATCH RFC 3/3] vdpa/mlx5: Disable VLAN support to support live migration

On Mon, Jun 20, 2022 at 5:02 PM Eugenio Perez Martin
<eperezma@...hat.com> wrote:
>
> On Mon, Jun 20, 2022 at 10:48 AM Jason Wang <jasowang@...hat.com> wrote:
> >
> > On Thu, Jun 16, 2022 at 9:28 PM Eli Cohen <elic@...dia.com> wrote:
> > >
> > > Current qemu code does not support live migration for devices supporting
> > > VLAN. Disable it.
> >
> > This looks like a bug that we need to fix in Qemu.
> >
>
> Not a but, but a lack of a feature :). Each cvq command needs new code
> to inject it at the destination, and only set mac cmd is implemented
> at the moment. Only to start simple.

I think we don't need this in the formal patch? (Anyhow we could
disable ctrl vlan vic command line)

Thanks

>
> Thanks!
>
> > Thanks
> >
> > >
> > > Note: this patch is provided just to enable testing with current qemu.
> > >
> > > Signed-off-by: Eli Cohen <elic@...dia.com>
> > > ---
> > >  drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > index 34bd81cb697c..1568cfdf07e6 100644
> > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > @@ -2172,7 +2172,6 @@ static u64 get_supported_features(struct mlx5_core_dev *mdev)
> > >         mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_MQ);
> > >         mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_STATUS);
> > >         mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_MTU);
> > > -       mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_CTRL_VLAN);
> > >
> > >         return mlx_vdpa_features;
> > >  }
> > > --
> > > 2.35.1
> > >
> >
>