linux-kernel - Re: [PATCH] ARM: dts: am33xx: Fix MMCHS0 dma properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <393f90de-44bd-d608-10e8-8db38e61aa67@linaro.org>
Date:   Mon, 20 Jun 2022 13:21:01 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     YuTong Chang <mtwget@...il.com>, bcousson@...libre.com
Cc:     tony@...mide.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-omap@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: am33xx: Fix MMCHS0 dma properties

On 20/06/2022 11:34, YuTong Chang wrote:
> According to technical manual(table 11-24),
> the DMA of MMCHS0 should be direct mapped.

Please wrap the commit according to Linux coding style.

https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586

> 
> Signed-off-by: YuTong Chang <mtwget@...il.com>
> ---
>  arch/arm/boot/dts/am33xx-l4.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
> index 7da42a5b959c..0446e2622d5f 100644
> --- a/arch/arm/boot/dts/am33xx-l4.dtsi
> +++ b/arch/arm/boot/dts/am33xx-l4.dtsi
> @@ -1502,8 +1502,8 @@ SYSC_OMAP2_SOFTRESET |
>  			mmc1: mmc@0 {
>  				compatible = "ti,am335-sdhci";
>  				ti,needs-special-reset;
> -				dmas = <&edma_xbar 24 0 0
> -					&edma_xbar 25 0 0>;
> +				dmas = <&edma 24 0
> +					&edma 25 0>;

This is still wrong from syntax point of view - should be two phandles,
so <edma ...>, <edma ...>

>  				dma-names = "tx", "rx";
>  				interrupts = <64>;
>  				reg = <0x0 0x1000>;


Best regards,
Krzysztof