[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d5a74aca024dd38030bb5edd38084d81b65e27fa.camel@mediatek.com>
Date: Mon, 20 Jun 2022 20:33:07 +0800
From: Rex-BC Chen <rex-bc.chen@...iatek.com>
To: Maxime Ripard <maxime@...no.tech>
CC: <chunkuang.hu@...nel.org>, <p.zabel@...gutronix.de>,
<daniel@...ll.ch>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <matthias.bgg@...il.com>,
<airlied@...ux.ie>, <devicetree@...r.kernel.org>,
<granquet@...libre.com>, <jitao.shi@...iatek.com>,
<linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
<msp@...libre.com>,
<Project_Global_Chrome_Upstream_Group@...iatek.com>,
<linux-mediatek@...ts.infradead.org>, <wenst@...omium.org>,
<linux-arm-kernel@...ts.infradead.org>,
<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v12 01/14] dt-bindings: mediatek,dpi: Add DP_INTF
compatible
On Mon, 2022-06-20 at 14:25 +0200, Maxime Ripard wrote:
> On Mon, Jun 20, 2022 at 08:10:15PM +0800, Bo-Chen Chen wrote:
> > From: Markus Schneider-Pargmann <msp@...libre.com>
> >
> > DP_INTF is similar to DPI but does not have the exact same feature
> > set
> > or register layouts.
> >
> > DP_INTF is the sink of the display pipeline that is connected to
> > the
> > DisplayPort controller and encoder unit. It takes the same clocks
> > as
> > DPI.
> >
> > In this patch, we also do these string replacement:
> > - s/mediatek/MediaTek/ in title.
> > - s/Mediatek/MediaTek/ in description.
> >
> > Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> > Signed-off-by: Guillaume Ranquet <granquet@...libre.com>
> > [Bo-Chen: Modify reviewers' comments.]
> > Signed-off-by: Bo-Chen Chen <rex-bc.chen@...iatek.com>
> > ---
> > .../bindings/display/mediatek/mediatek,dpi.yaml | 11 ++++++-
> > ----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > aml
> > index 77ee1b923991..d72f74632038 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > aml
> > @@ -4,16 +4,16 @@
> > $id:
> > http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml#
> > $schema: http://devicetree.org/meta-schemas/core.yaml#
> >
> > -title: mediatek DPI Controller Device Tree Bindings
> > +title: MediaTek DPI and DP_INTF Controller
> >
> > maintainers:
> > - CK Hu <ck.hu@...iatek.com>
> > - Jitao shi <jitao.shi@...iatek.com>
> >
> > description: |
> > - The Mediatek DPI function block is a sink of the display
> > subsystem and
> > - provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a
> > parallel
> > - output bus.
> > + The MediaTek DPI and DP_INTF function blocks are a sink of the
> > display
> > + subsystem and provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422
> > pixel data on a
> > + parallel output bus.
> >
> > properties:
> > compatible:
> > @@ -24,6 +24,7 @@ properties:
> > - mediatek,mt8183-dpi
> > - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> > + - mediatek,mt8195-dp_intf
>
> Underscores are frowned upon in the compatibles. See Section 2.3.1 of
> the device tree spec:
>
> > The compatible string should consist only of lowercase letters,
> > digits
> > and dashes, and should start with a letter. A single comma is
> > typically only used following a vendor prefix. Underscores should
> > not
> > be used.
>
> Maxime
Hello Maxime,
Thanks for review.
I will modify this compatible as "mediatek,mt8195-dp-intf"
BRs,
Bo-Chen
Powered by blists - more mailing lists