linux-kernel - RE: [PATCH 1/3] iommu: Add Visconti5 IOMMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYWPR01MB9420432737626348118C515F92B09@TYWPR01MB9420.jpnprd01.prod.outlook.com>
Date:   Mon, 20 Jun 2022 02:15:46 +0000
From:   <nobuhiro1.iwamatsu@...hiba.co.jp>
To:     <baolu.lu@...ux.intel.com>, <joro@...tes.org>, <will@...nel.org>,
        <robh+dt@...nel.org>, <jgg@...dia.com>
CC:     <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <iommu@...ts.linux-foundation.org>, <yuji2.ishikawa@...hiba.co.jp>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH 1/3] iommu: Add Visconti5 IOMMU driver

Hi,

> -----Original Message-----
> From: Baolu Lu <baolu.lu@...ux.intel.com>
> Sent: Wednesday, May 25, 2022 3:27 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@...hiba.co.jp>; Joerg Roedel <joro@...tes.org>; Will
> Deacon <will@...nel.org>; Rob Herring <robh+dt@...nel.org>; Jason
> Gunthorpe <jgg@...dia.com>
> Cc: baolu.lu@...ux.intel.com; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; iommu@...ts.linux-foundation.org; ishikawa
> yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@...hiba.co.jp>; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH 1/3] iommu: Add Visconti5 IOMMU driver
> 
> On 2022/5/25 09:31, Nobuhiro Iwamatsu wrote:
> > +static const struct iommu_ops visconti_atu_ops = {
> > +	.domain_alloc = visconti_atu_domain_alloc,
> > +	.probe_device = visconti_atu_probe_device,
> > +	.release_device = visconti_atu_release_device,
> > +	.device_group = generic_device_group,
> > +	.of_xlate = visconti_atu_of_xlate,
> > +	.pgsize_bitmap = ATU_IOMMU_PGSIZE_BITMAP,
> > +	.default_domain_ops = &(const struct iommu_domain_ops) {
> > +		.attach_dev = visconti_atu_attach_device,
> > +		.detach_dev = visconti_atu_detach_device,
> 
> The detach_dev callback is about to be deprecated. The new drivers should
> implement the default domain and blocking domain instead.

I see. I will update this with next version.

> 
> > +		.map = visconti_atu_map,
> > +		.unmap = visconti_atu_unmap,
> > +		.iova_to_phys = visconti_atu_iova_to_phys,
> > +		.free = visconti_atu_domain_free,
> > +	}
> > +};
> 
> Best regards,
> baolu

Best regards,
  Nobuhiro