[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <743a2629-f1a4-a12a-a7c0-90a2a28b68b4@sholland.org>
Date: Mon, 20 Jun 2022 22:53:30 -0500
From: Samuel Holland <samuel@...lland.org>
To: Mark Brown <broonie@...nel.org>
Cc: Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Liam Girdwood <lgirdwood@...il.com>,
Arnaud Ferraris <arnaud.ferraris@...labora.com>,
Jaroslav Kysela <perex@...ex.cz>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Maxime Ripard <mripard@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH 2/3] ASoC: sun50i-codec-analog: Add support for internal
bias
On 6/16/22 3:28 AM, Mark Brown wrote:
> On Thu, Jun 16, 2022 at 01:25:53AM -0500, Samuel Holland wrote:
>
>> +static int sun50i_a64_codec_probe(struct snd_soc_component *component)
>> +{
>> + struct sun50i_codec_analog *codec = snd_soc_component_get_drvdata(component);
>> +
>> + regmap_update_bits(component->regmap, SUN50I_ADDA_JACK_MIC_CTRL,
>> + BIT(SUN50I_ADDA_JACK_MIC_CTRL_INNERRESEN),
>> + codec->internal_bias_resistor <<
>> + SUN50I_ADDA_JACK_MIC_CTRL_INNERRESEN);
>> +
>> + return 0;
>> +}
>
> It doesn't make much practical difference but is there any reason this
> can't be done in the main device probe?
There's no particular reason, and doing it in the device probe would be much
simpler. I'll do that for v2.
Regards,
Samuel
Powered by blists - more mailing lists