[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJprQTiU+=ajKSWbFfbHuVxjEiybTPNez66Ob+4YZ+fXW_A@mail.gmail.com>
Date: Tue, 21 Jun 2022 20:07:50 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Yassine Oudjana <yassine.oudjana@...il.com>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Loic Poulain <loic.poulain@...aro.org>,
Yassine Oudjana <y.oudjana@...tonmail.com>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...ainline.org>,
Martin Botka <martin.botka@...ainline.org>,
Marijn Suijten <marijn.suijten@...ainline.org>,
Jami Kettunen <jami.kettunen@...ainline.org>,
linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] dt-bindings: clock: qcom,msm8996-apcc: Fix clocks
On Tue, 21 Jun 2022 at 19:07, Yassine Oudjana <yassine.oudjana@...il.com> wrote:
>
> From: Yassine Oudjana <y.oudjana@...tonmail.com>
>
> The clocks currently listed in clocks and clock-names are the ones
> supplied by this clock controller, not the ones it consumes. Replace
> them with the only clock it consumes - the on-board oscillator (XO),
> and make the properties required.
>
> Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>
> ---
> .../bindings/clock/qcom,msm8996-apcc.yaml | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml b/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml
> index a20cb10636dd..c4971234fef8 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml
> @@ -26,22 +26,18 @@ properties:
>
> clocks:
> items:
> - - description: Primary PLL clock for power cluster (little)
> - - description: Primary PLL clock for perf cluster (big)
> - - description: Alternate PLL clock for power cluster (little)
> - - description: Alternate PLL clock for perf cluster (big)
> + - description: XO source
>
> clock-names:
> items:
> - - const: pwrcl_pll
> - - const: perfcl_pll
> - - const: pwrcl_alt_pll
> - - const: perfcl_alt_pll
> + - const: xo
>
> required:
> - compatible
> - reg
> - '#clock-cells'
> + - clocks
> + - clock-names
I think we can not list them as required, as then older DT files won't
pass schema validation. But I'll leave this into the hands of Rob and
Krzyshtof.
>
> additionalProperties: false
>
> @@ -51,4 +47,7 @@ examples:
> compatible = "qcom,msm8996-apcc";
> reg = <0x6400000 0x90000>;
> #clock-cells = <1>;
> +
> + clocks = <&xo_board>;
> + clock-names = "xo";
> };
> --
> 2.36.1
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists