[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9ed319ee-07bd-253a-c7d8-a35d7d709da0@linaro.org>
Date: Tue, 21 Jun 2022 21:56:54 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Vinod Polimera <quic_vpolimer@...cinc.com>,
dri-devel@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, robdclark@...il.com,
dianders@...omium.org, swboyd@...omium.org,
quic_kalyant@...cinc.com, quic_sbillaka@...cinc.com
Subject: Re: [v3 2/5] drm/bridge: use atomic enable/disable callbacks for
panel bridge functions
On 21/06/2022 21:54, Dmitry Baryshkov wrote:
> On 21/06/2022 13:53, Vinod Polimera wrote:
>> Use atomic variants for panel bridge callback functions such that
>> certain states like self-refresh can be accessed as part of
>> enable/disable sequence.
>>
>> Signed-off-by: Vinod Polimera <quic_vpolimer@...cinc.com>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Oh, wait. NACK. This will not compile. Please fix compilation with this
patch.
>
>> ---
>> drivers/gpu/drm/bridge/panel.c | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/panel.c
>> b/drivers/gpu/drm/bridge/panel.c
>> index 0ee563e..59a3496 100644
>> --- a/drivers/gpu/drm/bridge/panel.c
>> +++ b/drivers/gpu/drm/bridge/panel.c
>> @@ -108,28 +108,28 @@ static void panel_bridge_detach(struct
>> drm_bridge *bridge)
>> drm_connector_cleanup(connector);
>> }
>> -static void panel_bridge_pre_enable(struct drm_bridge *bridge)
>> +static void panel_bridge_atomic_pre_enable(struct drm_bridge *bridge)
>> {
>> struct panel_bridge *panel_bridge =
>> drm_bridge_to_panel_bridge(bridge);
>> drm_panel_prepare(panel_bridge->panel);
>> }
>> -static void panel_bridge_enable(struct drm_bridge *bridge)
>> +static void panel_bridge_atomic_enable(struct drm_bridge *bridge)
>> {
>> struct panel_bridge *panel_bridge =
>> drm_bridge_to_panel_bridge(bridge);
>> drm_panel_enable(panel_bridge->panel);
>> }
>> -static void panel_bridge_disable(struct drm_bridge *bridge)
>> +static void panel_bridge_atomic_disable(struct drm_bridge *bridge)
>> {
>> struct panel_bridge *panel_bridge =
>> drm_bridge_to_panel_bridge(bridge);
>> drm_panel_disable(panel_bridge->panel);
>> }
>> -static void panel_bridge_post_disable(struct drm_bridge *bridge)
>> +static void panel_bridge_atomic_post_disable(struct drm_bridge *bridge)
>> {
>> struct panel_bridge *panel_bridge =
>> drm_bridge_to_panel_bridge(bridge);
>> @@ -158,10 +158,10 @@ static void panel_bridge_debugfs_init(struct
>> drm_bridge *bridge,
>> static const struct drm_bridge_funcs panel_bridge_bridge_funcs = {
>> .attach = panel_bridge_attach,
>> .detach = panel_bridge_detach,
>> - .pre_enable = panel_bridge_pre_enable,
>> - .enable = panel_bridge_enable,
>> - .disable = panel_bridge_disable,
>> - .post_disable = panel_bridge_post_disable,
>> + .atomic_pre_enable = panel_bridge_atomic_pre_enable,
>> + .atomic_enable = panel_bridge_atomic_enable,
>> + .atomic_disable = panel_bridge_atomic_disable,
>> + .atomic_post_disable = panel_bridge_atomic_post_disable,
>> .get_modes = panel_bridge_get_modes,
>> .atomic_reset = drm_atomic_helper_bridge_reset,
>> .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
>
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists