| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Jun 2022 03:13:24 +0800
From: kernel test robot <lkp@...el.com>
To: David Howells <dhowells@...hat.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:dhowells/linux-fs/rxrpc-multiqueue 3/5]
net/rxrpc/recvmsg.c:37:19: warning: variable 'sk' is uninitialized when used
here
tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/rxrpc-multiqueue
head: f37988fef6da3fdc3545e5a65eb9241f82f539f2
commit: 928631b5285b0aaebed61025256868cd126c9281 [3/5] rxrpc: Allow UDP socket sharing for AF_RXRPC service sockets
config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20220622/202206220335.rHqLFMRj-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project af6d2a0b6825e71965f3e2701a63c239fa0ad70f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/928631b5285b0aaebed61025256868cd126c9281
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/rxrpc-multiqueue
git checkout 928631b5285b0aaebed61025256868cd126c9281
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/rxrpc/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> net/rxrpc/recvmsg.c:37:19: warning: variable 'sk' is uninitialized when used here [-Wuninitialized]
call->notify_rx(sk, call, call->user_call_ID);
^~
net/rxrpc/recvmsg.c:26:17: note: initialize the variable 'sk' to silence this warning
struct sock *sk;
^
= NULL
1 warning generated.
vim +/sk +37 net/rxrpc/recvmsg.c
17926a79320afa net/rxrpc/ar-recvmsg.c David Howells 2007-04-26 18
17926a79320afa net/rxrpc/ar-recvmsg.c David Howells 2007-04-26 19 /*
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 20 * Post a call for attention by the socket or kernel service. Further
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 21 * notifications are suppressed by putting recvmsg_link on a dummy queue.
17926a79320afa net/rxrpc/ar-recvmsg.c David Howells 2007-04-26 22 */
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 23 void rxrpc_notify_socket(struct rxrpc_call *call)
17926a79320afa net/rxrpc/ar-recvmsg.c David Howells 2007-04-26 24 {
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 25 struct rxrpc_sock *rx;
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 26 struct sock *sk;
17926a79320afa net/rxrpc/ar-recvmsg.c David Howells 2007-04-26 27
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 28 _enter("%d", call->debug_id);
17926a79320afa net/rxrpc/ar-recvmsg.c David Howells 2007-04-26 29
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 30 if (!list_empty(&call->recvmsg_link))
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 31 return;
17926a79320afa net/rxrpc/ar-recvmsg.c David Howells 2007-04-26 32
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 33 rcu_read_lock();
17926a79320afa net/rxrpc/ar-recvmsg.c David Howells 2007-04-26 34
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 35 if (call->notify_rx) {
20acbd9a7aeee0 net/rxrpc/recvmsg.c David Howells 2017-11-02 36 spin_lock_bh(&call->notify_lock);
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 @37 call->notify_rx(sk, call, call->user_call_ID);
20acbd9a7aeee0 net/rxrpc/recvmsg.c David Howells 2017-11-02 38 spin_unlock_bh(&call->notify_lock);
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 39 goto out;
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 40 }
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 41
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 42 rx = rcu_dereference(call->socket);
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 43 if (rx) {
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 44 sk = &rx->sk;
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 45 if (sk->sk_state >= RXRPC_CLOSE)
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 46 goto out;
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 47
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 48 write_lock_bh(&rx->recvmsg_lock);
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 49 if (list_empty(&call->recvmsg_link)) {
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 50 rxrpc_get_call(call, rxrpc_call_got);
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 51 list_add_tail(&call->recvmsg_link, &rx->recvmsg_q);
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 52 }
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 53 write_unlock_bh(&rx->recvmsg_lock);
17926a79320afa net/rxrpc/ar-recvmsg.c David Howells 2007-04-26 54
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 55 if (!sock_flag(sk, SOCK_DEAD)) {
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 56 _debug("call %ps", sk->sk_data_ready);
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 57 sk->sk_data_ready(sk);
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 58 }
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 59 goto out;
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 60 }
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 61
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 62 if (call->service) {
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 63 struct rxrpc_service *b = call->service;
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 64
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 65 spin_lock_bh(&b->incoming_lock);
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 66 if (list_empty(&call->recvmsg_link)) {
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 67 list_add_tail(&call->recvmsg_link, &b->to_be_accepted);
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 68 b->nr_tba++;
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 69 }
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 70 list_for_each_entry(rx, &b->waiting_sockets, accept_link) {
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 71 sk = &rx->sk;
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 72 if (!sock_flag(sk, SOCK_DEAD))
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 73 sk->sk_data_ready(sk);
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 74 }
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 75 spin_unlock_bh(&b->incoming_lock);
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 76 }
17926a79320afa net/rxrpc/ar-recvmsg.c David Howells 2007-04-26 77
928631b5285b0a net/rxrpc/recvmsg.c David Howells 2022-06-16 78 out:
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 79 rcu_read_unlock();
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 80 _leave("");
248f219cb8bcbf net/rxrpc/recvmsg.c David Howells 2016-09-08 81 }
17926a79320afa net/rxrpc/ar-recvmsg.c David Howells 2007-04-26 82
:::::: The code at line 37 was first introduced by commit
:::::: 248f219cb8bcbfbd7f132752d44afa2df7c241d1 rxrpc: Rewrite the data and ack handling code
:::::: TO: David Howells <dhowells@...hat.com>
:::::: CC: David Howells <dhowells@...hat.com>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists