linux-kernel - Re: [PATCH] drm: Make drm_buddy a part of drm module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jun 2022 12:37:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Cai Huoqing <cai.huoqing@...ux.dev>
Cc:     kbuild-all@...ts.01.org,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: Make drm_buddy a part of drm module

Hi Cai,

I love your patch! Yet something to improve:

[auto build test ERROR on drm/drm-next]
[also build test ERROR on linus/master v5.19-rc2 next-20220617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Cai-Huoqing/drm-Make-drm_buddy-a-part-of-drm-module/20220621-095417
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: x86_64-rhel-8.3-kunit (https://download.01.org/0day-ci/archive/20220621/202206211209.5H0Eh2ff-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/517d5f44c861a5173eaa9a06efebe2ce2a6601a1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Cai-Huoqing/drm-Make-drm_buddy-a-part-of-drm-module/20220621-095417
        git checkout 517d5f44c861a5173eaa9a06efebe2ce2a6601a1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   ld: drivers/gpu/drm/drm_buddy.o: in function `drm_buddy_print':
>> drivers/gpu/drm/drm_buddy.c:745: undefined reference to `drm_printf'
>> ld: drivers/gpu/drm/drm_buddy.c:757: undefined reference to `drm_printf'
   ld: drivers/gpu/drm/drm_buddy.c:763: undefined reference to `drm_printf'
   ld: drivers/gpu/drm/drm_buddy.c:765: undefined reference to `drm_printf'
   ld: drivers/gpu/drm/drm_buddy.c:761: undefined reference to `drm_printf'
   ld: drivers/gpu/drm/drm_buddy.o:drivers/gpu/drm/drm_buddy.c:757: more undefined references to `drm_printf' follow


vim +745 drivers/gpu/drm/drm_buddy.c

6387a3c4b0c45a Arunpravin 2022-01-18  734  
6387a3c4b0c45a Arunpravin 2022-01-18  735  /**
6387a3c4b0c45a Arunpravin 2022-01-18  736   * drm_buddy_print - print allocator state
6387a3c4b0c45a Arunpravin 2022-01-18  737   *
6387a3c4b0c45a Arunpravin 2022-01-18  738   * @mm: DRM buddy manager
6387a3c4b0c45a Arunpravin 2022-01-18  739   * @p: DRM printer to use
6387a3c4b0c45a Arunpravin 2022-01-18  740   */
6387a3c4b0c45a Arunpravin 2022-01-18  741  void drm_buddy_print(struct drm_buddy *mm, struct drm_printer *p)
6387a3c4b0c45a Arunpravin 2022-01-18  742  {
6387a3c4b0c45a Arunpravin 2022-01-18  743  	int order;
6387a3c4b0c45a Arunpravin 2022-01-18  744  
6387a3c4b0c45a Arunpravin 2022-01-18 @745  	drm_printf(p, "chunk_size: %lluKiB, total: %lluMiB, free: %lluMiB\n",
6387a3c4b0c45a Arunpravin 2022-01-18  746  		   mm->chunk_size >> 10, mm->size >> 20, mm->avail >> 20);
6387a3c4b0c45a Arunpravin 2022-01-18  747  
6387a3c4b0c45a Arunpravin 2022-01-18  748  	for (order = mm->max_order; order >= 0; order--) {
6387a3c4b0c45a Arunpravin 2022-01-18  749  		struct drm_buddy_block *block;
6387a3c4b0c45a Arunpravin 2022-01-18  750  		u64 count = 0, free;
6387a3c4b0c45a Arunpravin 2022-01-18  751  
6387a3c4b0c45a Arunpravin 2022-01-18  752  		list_for_each_entry(block, &mm->free_list[order], link) {
6387a3c4b0c45a Arunpravin 2022-01-18  753  			BUG_ON(!drm_buddy_block_is_free(block));
6387a3c4b0c45a Arunpravin 2022-01-18  754  			count++;
6387a3c4b0c45a Arunpravin 2022-01-18  755  		}
6387a3c4b0c45a Arunpravin 2022-01-18  756  
6387a3c4b0c45a Arunpravin 2022-01-18 @757  		drm_printf(p, "order-%d ", order);
6387a3c4b0c45a Arunpravin 2022-01-18  758  
6387a3c4b0c45a Arunpravin 2022-01-18  759  		free = count * (mm->chunk_size << order);
6387a3c4b0c45a Arunpravin 2022-01-18  760  		if (free < SZ_1M)
6387a3c4b0c45a Arunpravin 2022-01-18  761  			drm_printf(p, "free: %lluKiB", free >> 10);
6387a3c4b0c45a Arunpravin 2022-01-18  762  		else
6387a3c4b0c45a Arunpravin 2022-01-18  763  			drm_printf(p, "free: %lluMiB", free >> 20);
6387a3c4b0c45a Arunpravin 2022-01-18  764  
6387a3c4b0c45a Arunpravin 2022-01-18  765  		drm_printf(p, ", pages: %llu\n", count);
6387a3c4b0c45a Arunpravin 2022-01-18  766  	}
6387a3c4b0c45a Arunpravin 2022-01-18  767  }
6387a3c4b0c45a Arunpravin 2022-01-18  768  EXPORT_SYMBOL(drm_buddy_print);
6387a3c4b0c45a Arunpravin 2022-01-18  769  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp