linux-kernel - Re: [PATCH 3/3] drm/dp_mst: Get rid of old comment in drm_atomic_get_mst_topology

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Jun 2022 15:37:38 -0400
From:   Lyude Paul <lyude@...hat.com>
To:     "Lin, Wayne" <Wayne.Lin@....com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Jani Nikula <jani.nikula@...el.com>,
        "Lakha, Bhawanpreet" <Bhawanpreet.Lakha@....com>,
        Rajkumar Subbiah <rsubbia@...eaurora.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] drm/dp_mst: Get rid of old comment in
 drm_atomic_get_mst_topology_state docs

Thanks! Will push these two patches upstream

On Mon, 2022-06-13 at 09:59 +0000, Lin, Wayne wrote:
> [Public]
> 
> Hi Lyude,
> 
> Feel free to add
> Reviewed-by: Wayne Lin <Wayne.Lin@....com>
> 
> > -----Original Message-----
> > From: Lyude Paul <lyude@...hat.com>
> > Sent: Friday, June 3, 2022 4:18 AM
> > To: dri-devel@...ts.freedesktop.org
> > Cc: David Airlie <airlied@...ux.ie>; Daniel Vetter <daniel@...ll.ch>;
> > Thomas
> > Zimmermann <tzimmermann@...e.de>; Lin, Wayne
> > <Wayne.Lin@....com>; Jani Nikula <jani.nikula@...el.com>; Lakha,
> > Bhawanpreet <Bhawanpreet.Lakha@....com>; Rajkumar Subbiah
> > <rsubbia@...eaurora.org>; open list <linux-kernel@...r.kernel.org>
> > Subject: [PATCH 3/3] drm/dp_mst: Get rid of old comment in
> > drm_atomic_get_mst_topology_state docs
> > 
> > We don't actually care about connection_mutex here anymore, so let's get
> > rid of the comment mentioning it in this function's kdocs.
> > 
> > Signed-off-by: Lyude Paul <lyude@...hat.com>
> > ---
> >  drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> > b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> > index d6e595b95f07..9f96132a5d74 100644
> > --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> > +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> > @@ -5458,8 +5458,7 @@
> > EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
> >   *
> >   * This function wraps drm_atomic_get_priv_obj_state() passing in the MST
> > atomic
> >   * state vtable so that the private object state returned is that of a
> > MST
> > - * topology object. Also, drm_atomic_get_private_obj_state() expects the
> > caller
> > - * to care of the locking, so warn if don't hold the connection_mutex.
> > + * topology object.
> >   *
> >   * RETURNS:
> >   *
> > --
> > 2.35.3
> 
> --
> Regards,
> Wayne Lin
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat