linux-kernel - Re: [PATCH] mips: sgi-ip22: Remove duplicate 'of' in two places.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220621194757.ay4z6bbwev7ibggs@pengutronix.de>
Date:   Tue, 21 Jun 2022 21:47:57 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Jiang Jian <jiangjian@...rlc.com>
Cc:     tsbogend@...ha.franken.de, srinivas.kandagatla@...aro.org,
        rafael@...nel.org, sudeep.holla@....com,
        alexandre.belloni@...tlin.com, xkernel.wang@...mail.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: sgi-ip22: Remove duplicate 'of' in two places.

The Subject speaks about two places, there is only one change here
however?

On Wed, Jun 22, 2022 at 12:21:14AM +0800, Jiang Jian wrote:
> file: ./arch/mips/sgi-ip22/ip22-gio.c
> line: 44
>   * @ids: array of of device match structures to search in
> changed to
>   * @ids: array of device match structures to search in

I know writing a sensible commit log is hard, but this is really very
useless. This is a plain repetition of the diff below.

Additionally I'm not sure the patch is right. The comment speaks about
of (= open firmware) devices. So if you want to improve here, maybe make
it read

+ * @match: array gio_device_id structures to search in

But please double check this is indeed sensible; I didn't.

(But yes, @ids is wrong, the parameter is named match.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)