[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGS_qxqnCvTnE-cGd-LNnhCMsz5YE3Ea9jw_OqNDwjQQ9TGpGg@mail.gmail.com>
Date: Tue, 21 Jun 2022 13:29:24 -0700
From: Daniel Latypov <dlatypov@...gle.com>
To: David Gow <davidgow@...gle.com>
Cc: Brendan Higgins <brendanhiggins@...gle.com>,
Luis Chamberlain <mcgrof@...nel.org>,
Jeremy Kerr <jk@...econstruct.com.au>,
Shuah Khan <skhan@...uxfoundation.org>,
Andrew Jeffery <andrew@...id.au>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Andra Paraschiv <andraprs@...zon.com>,
Longpeng <longpeng2@...wei.com>, Paraschiv@...gle.com,
Christophe Leroy <christophe.leroy@...roup.eu>,
kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org,
Maíra Canal <maira.canal@....br>,
linux-mmc@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
openbmc@...ts.ozlabs.org, linux-usb@...r.kernel.org,
linux-modules@...r.kernel.org,
Matt Johnston <matt@...econstruct.com.au>
Subject: Re: [PATCH v2 2/5] kunit: flatten kunit_suite*** to kunit_suite** in .kunit_test_suites
On Tue, Jun 21, 2022 at 1:54 AM 'David Gow' via KUnit Development
<kunit-dev@...glegroups.com> wrote:
>
> From: Daniel Latypov <dlatypov@...gle.com>
>
> We currently store kunit suites in the .kunit_test_suites ELF section as
> a `struct kunit_suite***` (modulo some `const`s).
> For every test file, we store a struct kunit_suite** NULL-terminated array.
>
> This adds quite a bit of complexity to the test filtering code in the
> executor.
>
> Instead, let's just make the .kunit_test_suites section contain a single
> giant array of struct kunit_suite pointers, which can then be directly
> manipulated. This array is not NULL-terminated, and so none of the test
> filtering code needs to NULL-terminate anything.
>
> Tested-by: Maíra Canal <maira.canal@....br>
> Signed-off-by: Daniel Latypov <dlatypov@...gle.com>
> Co-developed-by: David Gow <davidgow@...gle.com>
> Signed-off-by: David Gow <davidgow@...gle.com>
> ---
>
> Changes since v1:
> https://lore.kernel.org/linux-kselftest/20220618090310.1174932-3-davidgow@google.com/
> - No longer NULL-terminate generated suite_sets
Nice!
Thanks for picking and cleaning this up!
Daniel
Powered by blists - more mailing lists