[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bc8d3d9d-fa62-7e90-9809-449b7338800d@intel.com>
Date: Tue, 21 Jun 2022 13:40:23 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
"Gustavo A. R. Silva" <gustavoars@...nel.org>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-hardening@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH][next] iavf: Replace one-element array
in struct virtchnl_iwarp_qvlist_info and iavf_qvlist_info
On 6/17/2022 9:00 AM, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping (after more than a year after I sent this patch :O):
>
> Who can review and/or take this patch, please?
Hi Gustavo,
IIRC this could cause some issues with the expectations of the virtchnl
structures [1] for compatibility. There was a direction that we were
going to head to resolve this. Unfortunately, the person who, I believe,
was going to make this change is out for a couple of weeks. I will ask
around and see if I can get any updates on this work. Otherwise, I'll
ask him when he returns.
Thanks,
Tony
[1]
https://lore.kernel.org/intel-wired-lan/f2fe13346f1d44ee9047254a95914d00@intel.com/
> Thanks
> --
> Gustavo
>
> On 5/26/21 01:04, Gustavo A. R. Silva wrote:
>> There is a regular need in the kernel to provide a way to declare
>> having a
>> dynamically sized set of trailing elements in a structure. Kernel code
>> should always use “flexible array members”[1] for these cases. The older
>> style of one-element or zero-length arrays should no longer be used[2].
>>
>> Refactor the code according to the use of a flexible-array member in
>> struct
>> virtchnl_iwarp_qvlist_info and iavf_qvlist_info instead of one-element
>> array,
>> and use the flex_array_size() helper.
>>
>> [1] https://en.wikipedia.org/wiki/Flexible_array_member
>> [2]
>> https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays
>>
>>
>> Link: https://github.com/KSPP/linux/issues/79
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
>
Powered by blists - more mailing lists