lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220621211126.q4crb44djniriqo7@pengutronix.de>
Date:   Tue, 21 Jun 2022 23:11:26 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Jiang Jian <jiangjian@...rlc.com>
Cc:     jic23@...nel.org, lars@...afoo.de, ardeleanalex@...il.com,
        antoniu.miclaus@...log.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio:magnetometer:hmc5843: Remove duplicate 'the' in two
 places.

On Wed, Jun 22, 2022 at 12:40:56AM +0800, Jiang Jian wrote:
> file: drivers/iio/magnetometer/hmc5843_core.c
> line: 3
>   * Device driver for the the HMC5843 multi-chip module designed
> changed to
>   * Device driver for the HMC5843 multi-chip module designed
> 
> Signed-off-by: Jiang Jian <jiangjian@...rlc.com>

The patch looks good, the commit log however is bad and wrong. There
are no "two places". I'd just write:

	iio:magnetometer:hmc5843: Remove duplicate 'the'

	Fix an obvious typing error, found by spellcheck(1).

	Signed-off-....

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ