linux-kernel - Re: [PATCH] s390/net: Fix duplicate 'the' in two places

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220621153222.0d328987@kernel.org>
Date:   Tue, 21 Jun 2022 15:32:22 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiang Jian <jiangjian@...rlc.com>
Cc:     wintera@...ux.ibm.com, wenjia@...ux.ibm.com, hca@...ux.ibm.com,
        gor@...ux.ibm.com, agordeev@...ux.ibm.com,
        borntraeger@...ux.ibm.com, svens@...ux.ibm.com,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/net: Fix duplicate 'the' in two places

Please add the version to the patch subject.
This is the second versions, AFAIU so it should have had
[PATCH v2] in the subject line.

On Wed, 22 Jun 2022 00:07:56 +0800 Jiang Jian wrote:
> file: drivers/s390/net/qeth_core_main.c
> line: 3568
>                 /*
>                  * there's no outstanding PCI any more, so we
>                  * have to request a PCI to be sure the the PCI
>                  * will wake at some time in the future then we
>                  * can flush packed buffers that might still be
>                  * hanging around, which can happen if no
>                  * further send was requested by the stack
>                  */
> changed to:
> 		/*
>                  * there's no outstanding PCI any more, so we
>                  * have to request a PCI to be sure the PCI
>                  * will wake at some time in the future. Then we
>                  * can flush packed buffers that might still be
>                  * hanging around, which can happen if no
>                  * further send was requested by the stack
>                  */

That's basically a copy of the diff, please describe the why and what
not how.

> Signed-off-by: Jiang Jian <jiangjian@...rlc.com>
> ---
>  drivers/s390/net/qeth_core_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index 9e54fe76a9b2..5248f97ee7a6 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -3565,8 +3565,8 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index,
>  			if (!atomic_read(&queue->set_pci_flags_count)) {
>  				/*
>  				 * there's no outstanding PCI any more, so we
> -				 * have to request a PCI to be sure the the PCI
> -				 * will wake at some time in the future then we
> +                 * have to request a PCI to be sure the PCI
> +                 * will wake at some time in the future. Then we

You broke the whitespace now.