linux-kernel - RE: [PATCH v5 4/5] selftests/bpf: Add test for unreleased key references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62b247b975506_162742082f@john.notmuch>
Date:   Tue, 21 Jun 2022 15:35:37 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Roberto Sassu <roberto.sassu@...wei.com>, ast@...nel.org,
        daniel@...earbox.net, andrii@...nel.org, kpsingh@...nel.org,
        john.fastabend@...il.com, songliubraving@...com, kafai@...com,
        yhs@...com
Cc:     dhowells@...hat.com, keyrings@...r.kernel.org, bpf@...r.kernel.org,
        netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Roberto Sassu <roberto.sassu@...wei.com>
Subject: RE: [PATCH v5 4/5] selftests/bpf: Add test for unreleased key
 references

Roberto Sassu wrote:
> Ensure that the verifier detects the attempt of acquiring a reference of a
> key through the helper bpf_lookup_user_key(), without releasing that
> reference with bpf_key_put(), and refuses to load the program.
> 
> Signed-off-by: Roberto Sassu <roberto.sassu@...wei.com>
> ---

Any reason not to add these to ./verifier/ref_tracking.c tests? Seems it
might be easier to follow there and test both good/bad cases.