linux-kernel - Re: [PATCH] xfs: return when delta equals 0 in xfs_mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANubcdUO55kSFc7USg-EsgE5uvQR08s8wcxrf4=vHk8VOiisjw@mail.gmail.com>
Date:   Tue, 21 Jun 2022 15:04:20 +0800
From:   Stephen Zhang <starzhangzsd@...il.com>
To:     Dave Chinner <david@...morbit.com>
Cc:     djwong@...nel.org, zhangshida <zhangshida@...inos.cn>,
        linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH] xfs: return when delta equals 0 in xfs_mod_freecounter

Dave Chinner <david@...morbit.com> 于2022年6月21日周二 12:35写道：
>
> On Tue, Jun 21, 2022 at 11:11:13AM +0800, Shida Zhang wrote:
> > There are cases that xfs_mod_freecounter() will get called when delta
> > equals 0 while it's unnecessary.
>
> AFAICT all of the call paths are guarded by checks to ensure the
> delta is, in fact, not zero. i.e. if the delta is zero, we shouldn't
> be calling xfs_mod_fdblocks() or xfs_mod_frextents() at all.
>
> Can you explain in more detail what code path leads to delta = 0
> here?
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@...morbit.com

Yeah. I will give it in another v2 version patch.

Cheers,

Stephen.