linux-kernel - Re: [PATCH] perf: Adjust perf-inject output data offset for backward compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+PGoB_H2iKwvTA1xEGmyqccefipdrnS_GxZBixZTAe2bvkDrg@mail.gmail.com>
Date:   Mon, 20 Jun 2022 18:35:52 -0700
From:   Raul Silvera <rsilvera@...mo.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Dave Marchevsky <davemarchevsky@...com>,
        Colin Ian King <colin.king@...el.com>,
        Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: Adjust perf-inject output data offset for backward compatibility

On Mon, Jun 20, 2022 at 11:54 AM Adrian Hunter <adrian.hunter@...el.com> wrote:
>
> This looks too late since, although the header comes before the data,
> it also gets written afterwards (at_exit == true).  It would be
> better if we could rely on header->data_offset at this point.
>

Thank you. You're right. We can rely on header->data_offset at this
point as it is
adjusted upfront in __cmd_inject. Will send an updated patch.

Raúl E. Silvera
Software Engineer
waymo.com