linux-kernel - Re: [PATCH v4 13/34] test_printf: Drop requirement that sprintf not write past nul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220621075223.qpiatsusjbu6zj7a@moria.home.lan>
Date:   Tue, 21 Jun 2022 03:52:23 -0400
From:   Kent Overstreet <kent.overstreet@...il.com>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org, pmladek@...e.com,
        rostedt@...dmis.org, enozhatsky@...omium.org, willy@...radead.org
Subject: Re: [PATCH v4 13/34] test_printf: Drop requirement that sprintf not
 write past nul

On Tue, Jun 21, 2022 at 09:19:55AM +0200, Rasmus Villemoes wrote:
> On 20/06/2022 02.42, Kent Overstreet wrote:
> > The current test code checks that sprintf never writes past the
> > terminating nul. This is a rather strange requirement, completely
> > separate from writing past the end of the buffer, which of course we
> > can't do
> 
> And which of course you don't check anymore. So any statement about "all
> tests passing after these patches" is not worth much.
> 
> So NAK in this form, but perhaps if/when my year-old patch gets picked
> up (or you could include it in the series) we can talk about eliminating
> the check for past-nul-before-end-of-buffer writes.

I'm more than happy to pick up your patch, please send it to me.