linux-kernel - Re: [PATCH v2 2/2] vfio/pci: Remove console drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jun 2022 02:15:54 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Alex Williamson <alex.williamson@...hat.com>, corbet@....net,
        maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
        tzimmermann@...e.de, airlied@...ux.ie, daniel@...ll.ch,
        deller@....de, gregkh@...uxfoundation.org
Cc:     linux-fbdev@...r.kernel.org, kvm@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, Gerd Hoffmann <kraxel@...hat.com>,
        Laszlo Ersek <lersek@...hat.com>
Subject: Re: [PATCH v2 2/2] vfio/pci: Remove console drivers

Hello Alex,

On 6/16/22 22:38, Alex Williamson wrote:
> Console drivers can create conflicts with PCI resources resulting in
> userspace getting mmap failures to memory BARs.  This is especially
> evident when trying to re-use the system primary console for userspace
> drivers.  Use the aperture helpers to remove these conflicts.
> 
> Reported-by: Laszlo Ersek <lersek@...hat.com>
> Suggested-by: Gerd Hoffmann <kraxel@...hat.com>
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
> ---

Patch looks good to me. 

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat