linux-kernel - Re: [PATCH v5 -next] usb: xhci: disable irq during initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13e54c18-7a58-b6bd-0399-273a109ee42e@kylinos.cn>
Date:   Tue, 21 Jun 2022 16:40:50 +0800
From:   谢泓宇 <xiehongyu1@...inos.cn>
To:     Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Hongyu Xie <xy521521@...il.com>, mathias.nyman@...el.com,
        gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        125707942@...com, wangqi@...inos.cn, xiongxin@...inos.cn
Subject: Re: [PATCH v5 -next] usb: xhci: disable irq during initialization

Hi,

It looks fine.
Thanks for all the advices and cleanups.

On 2022/6/21 16:25, Mathias Nyman wrote:
> Hi
> 
> On 16.6.2022 11.38, Hongyu Xie wrote:
>> irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
>> in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
>> It's possible that you will receive thousands of interrupt requests
>> after initialization for 2.0 roothub. And you will get a lot of
>> warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
>> disabled?". This amount of interrupt requests will cause the entire
>> system to freeze.
>> This problem was first found on a device with ASM2142 host controller
>> on it.
>>
>> Signed-off-by: Hongyu Xie <xiehongyu1@...inos.cn>
>> --
> Thanks, added.
> Did some non-functional cleanups, mostly to the old debug messages this patch
> moves around:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/commit/?h=for-usb-linus&id=2d1fa9b0b08bb841fde9136c249f632eb04a1e00
> 
> Let me know if you disagree with the changes
> 
> -Mathias
  -Hongyu