linux-kernel - Re: [PATCH] mm/damon: Use set_huge_pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f79ad32f-50a3-be1a-0cac-d00f579e7077@linux.alibaba.com>
Date:   Tue, 21 Jun 2022 16:45:39 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     SeongJae Park <sj@...nel.org>
Cc:     akpm@...ux-foundation.org, mike.kravetz@...cle.com,
        songmuchun@...edance.com, damon@...ts.linux.dev,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] mm/damon: Use set_huge_pte_at() to make huge pte old

Hi SeongJae,

On 6/21/2022 1:27 AM, SeongJae Park wrote:
> Hi Baolin,
> 
> On Mon, 20 Jun 2022 10:34:42 +0800 Baolin Wang <baolin.wang@...ux.alibaba.com> wrote:
> 
>> The huge_ptep_set_access_flags() can not make the huge pte old according
>> to the discussion [1], that means we will always mornitor the young state
>> of the hugetlb though we stopped accessing the hugetlb, as a result DAMON
>> will get inaccurate accessing statistics.
>>
>> So changing to use set_huge_pte_at() to make the huge pte old to fix this
>> issue.
>>
>> [1] https://lore.kernel.org/all/Yqy97gXI4Nqb7dYo@arm.com/
>>
>> Fixes: 49f4203aae06 ("mm/damon: add access checking for hugetlb pages")
> 
> As the commit has merged in from v5.17, I guess it would be better to do below?
> 
> Cc: <stable@...r.kernel.org>

Yes, thanks for reminding. Hope Andrew can help to add the stable tag 
when picking up this patch.

> 
>> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> 
> Other than that,
> 
> Reviewed-by: SeongJae Park <sj@...nel.org>

Thanks.