linux-kernel - Re: [PATCH] iio: aligned '*' each line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeXCaoKQ94x+ehXWMi5zeysJdjrzS1WE2oZCUAeLbCzvQ@mail.gmail.com>
Date:   Tue, 21 Jun 2022 10:56:18 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jiang Jian <jiangjian@...rlc.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: aligned '*' each line

On Tue, Jun 21, 2022 at 8:57 AM Jiang Jian <jiangjian@...rlc.com> wrote:
>
> Consider '*' alignment in comments

Subject should start with "iio: dac: ad5380: ..."

The commit message should follow English grammar (missed period in
your case) and explain a little bit more, e.g. "Consider '*' alignment
in the comments of struct ad5380_chip_info declaration".

...

>   * @channel_template:  channel specification template
>   * @num_channels:      number of channels
>   * @int_vref:          internal vref in uV
> -*/
> + */
>

While at it, drop the unneeded blank line here.

>  struct ad5380_chip_info {


-- 
With Best Regards,
Andy Shevchenko