[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABVgOS=nmio08_==bOhXK1qLBoGVBO9=7A9srcp6PBUS06CTqA@mail.gmail.com>
Date: Tue, 21 Jun 2022 17:38:38 +0800
From: David Gow <davidgow@...gle.com>
To: José Expósito <jose.exposito89@...il.com>
Cc: Javier Martinez Canillas <javierm@...hat.com>,
Daniel Latypov <dlatypov@...gle.com>,
Thomas Zimmermann <tzimmermann@...e.de>,
maarten.lankhorst@...ux.intel.com,
Maxime Ripard <mripard@...nel.org>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Jani Nikula <jani.nikula@...ux.intel.com>,
Maíra Canal <maira.canal@....br>,
Isabella Basso <isabbasso@...eup.net>, magalilemes00@...il.com,
tales.aparecida@...il.com, dri-devel@...ts.freedesktop.org,
KUnit Development <kunit-dev@...glegroups.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Maxime Ripard <maxime@...no.tech>
Subject: Re: [PATCH v4 3/3] drm/doc: Add KUnit documentation
On Tue, Jun 21, 2022 at 12:06 AM José Expósito
<jose.exposito89@...il.com> wrote:
>
> Explain how to run the KUnit tests present in the DRM subsystem and
> clarify why the UML-only options were not added to the configuration
> file present in drivers/gpu/drm/.kunitconfig [1] [2].
>
> [1] https://lore.kernel.org/dri-devel/CABVgOSn8i=LO5p7830h2XU1Jgg0KrN0qTnxkOMhf1oTgxjaKKw@mail.gmail.com/
> [2] https://lore.kernel.org/dri-devel/CAGS_qxqpiCim_sy1LDK7PLwVgWf-LKW+uNFTGM=T7ydk-dYcEw@mail.gmail.com/
>
> Reviewed-by: Maxime Ripard <maxime@...no.tech>
> Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>
> Acked-by: Thomas Zimmermann <tzimmermann@...e.de>
> Signed-off-by: José Expósito <jose.exposito89@...il.com>
> ---
This looks good (and doesn't seem to introduce any 'make htmldocs'
build issues on my machine).
You could also mention that using --arch=x86_64 (or similar) instead
of the UML options is another, equally viable option for running the
tests. That'd make it more obvious how to run on different
architectures: UML, while a good default, is quite different to other
architectures in not having any PCI support out-of-the-box.
(Maybe we should make the --arch=um default config include these
options? Or have um-pci as another architecture. We did decide not to
bother with SMP and x86, though...)
Regardless, this is
Reviewed-by: David Gow <davidgow@...gle.com>
Cheers,
-- David
Download attachment "smime.p7s" of type "application/pkcs7-signature" (4003 bytes)
Powered by blists - more mailing lists