[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9d683b37-abb0-a0d6-417a-b5f7c97673c5@marcan.st>
Date: Tue, 21 Jun 2022 19:07:02 +0900
From: Hector Martin <marcan@...can.st>
To: Sven Peter <sven@...npeter.dev>,
Alyssa Rosenzweig <alyssa@...enzweig.io>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: apple: Re-parent ANS2 power domains
On 03/06/2022 02.42, Sven Peter wrote:
> From: Hector Martin <marcan@...can.st>
>
> Turns out that the APCIE_ST*_SYS domains do hard-depend on ANS2, so
> without this they refuse to power up.
>
> Signed-off-by: Hector Martin <marcan@...can.st>
> Reviewed-by: Sven Peter <sven@...npeter.dev>
> Signed-off-by: Sven Peter <sven@...npeter.dev>
> ---
> arch/arm64/boot/dts/apple/t8103-pmgr.dtsi | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
> index fc51bc872468..a6dbb1f485d8 100644
> --- a/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
> @@ -725,11 +725,6 @@ ps_ans2: power-controller@3f0 {
> #power-domain-cells = <0>;
> #reset-cells = <0>;
> label = "ans2";
> - /*
> - * The ADT makes ps_apcie_st depend on ps_ans2 instead, but this
> - * doesn't make much sense since ANS2 uses APCIE_ST.
> - */
> - power-domains = <&ps_apcie_st>;
> };
>
> ps_gfx: power-controller@3f8 {
> @@ -836,7 +831,7 @@ ps_apcie_st: power-controller@418 {
> #power-domain-cells = <0>;
> #reset-cells = <0>;
> label = "apcie_st";
> - power-domains = <&ps_apcie>;
> + power-domains = <&ps_apcie>, <&ps_ans2>;
> };
>
> ps_ane_sys: power-controller@470 {
Applied both patches to asahi-soc/dt. Thanks!
--
Hector Martin (marcan@...can.st)
Public Key: https://mrcn.st/pub
Powered by blists - more mailing lists