linux-kernel - Re: [PATCH v2 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Jun 2022 13:52:05 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     linux-iio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH v2 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics

On Tue, Jun 21, 2022 at 01:37:54PM +0300, Andy Shevchenko wrote:
> First of all, the additional conversion from vIRQ, and this is exactly
> what is returned by platform_get_irq_byname(), to vIRQ is not needed.
> Hence, drop no-op call to irq_of_parse_and_map().

Actually this patch is not correct. The MFD supplies IRQ lines without any
domain behind it, because of that the supplied list of IRQs is abstract to the
hardware and has no meaning in the Linux kernel. I dunno how it's supposed to
work (perhaps it involves the GIC driver hooks for IMX23/28 platforms).

-- 
With Best Regards,
Andy Shevchenko