linux-kernel - Re: [PATCH v7 17/39] KVM: x86: hyper-v: L2 TLB flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e22c7352-bafa-3ebf-c842-ed706579a619@redhat.com>
Date:   Tue, 21 Jun 2022 14:59:58 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>, kvm@...r.kernel.org
Cc:     Sean Christopherson <seanjc@...gle.com>,
        Maxim Levitsky <mlevitsk@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        Siddharth Chandrasekaran <sidcha@...zon.de>,
        Yuan Yao <yuan.yao@...ux.intel.com>,
        linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 17/39] KVM: x86: hyper-v: L2 TLB flush

On 6/13/22 15:39, Vitaly Kuznetsov wrote:
> -	tlb_flush_fifo = kvm_hv_get_tlb_flush_fifo(vcpu);
> +	tlb_flush_fifo = kvm_hv_get_tlb_flush_fifo(vcpu, is_guest_mode(vcpu));
>   

Any reason to add this parameter?  It is always set to 
is_guest_mode(vcpu) and, even if it wasn't, I would add the parameter 
directly in patch 11.

Paolo