linux-kernel - Re: [PATCH -next] net: pcs: pcs-xpcs: Fix build error when CONFIG_PCS_XPCS=y && CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30a683ae5375ca67d10563fe8475074baeb3d7d3.camel@redhat.com>
Date:   Tue, 21 Jun 2022 15:34:01 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Zheng Bin <zhengbin13@...wei.com>, andrew@...n.ch,
        hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, boon.leong.ong@...el.com,
        rmk+kernel@...linux.org.uk, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     gaochao49@...wei.com
Subject: Re: [PATCH -next] net: pcs: pcs-xpcs: Fix build error when
 CONFIG_PCS_XPCS=y && CONFIG_PHYLINK=m

Hello,

On Tue, 2022-06-21 at 21:12 +0800, Zheng Bin wrote:
> If CONFIG_PCS_XPCS=y, CONFIG_PHYLINK=m, bulding fails:
> 
> drivers/net/pcs/pcs-xpcs.o: in function `xpcs_do_config':
> pcs-xpcs.c:(.text+0x64f): undefined reference to `phylink_mii_c22_pcs_encode_advertisement'
> drivers/net/pcs/pcs-xpcs.o: in function `xpcs_get_state':
> pcs-xpcs.c:(.text+0x10f8): undefined reference to `phylink_mii_c22_pcs_decode_state
> 
> Make PCS_XPCS depends on PHYLINK to fix this.
> 
> Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
> Signed-off-by: Zheng Bin <zhengbin13@...wei.com>
> ---
>  drivers/net/pcs/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/pcs/Kconfig b/drivers/net/pcs/Kconfig
> index 22ba7b0b476d..faec931b1e65 100644
> --- a/drivers/net/pcs/Kconfig
> +++ b/drivers/net/pcs/Kconfig
> @@ -8,6 +8,7 @@ menu "PCS device drivers"
>  config PCS_XPCS
>  	tristate "Synopsys DesignWare XPCS controller"
>  	depends on MDIO_DEVICE && MDIO_BUS
> +	depends on PHYLINK
>  	help
>  	  This module provides helper functions for Synopsys DesignWare XPCS
>  	  controllers.
> --
> 2.31.1

Thank you for the patch. There is already a similar fix pending:

https://patchwork.kernel.org/project/netdevbpf/patch/6959a6a51582e8bc2343824d0cee56f1db246e23.1655797997.git.pabeni@redhat.com/

Cheers,

Paolo