linux-kernel - Re: [PATCH] net: ipa: remove unexpected word "the"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jun 2022 08:47:32 -0500
From:   Alex Elder <elder@...aro.org>
To:     Jiang Jian <jiangjian@...rlc.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc:     elder@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ipa: remove unexpected word "the"

On 6/21/22 3:50 AM, Jiang Jian wrote:
> there is an unexpected word "the" in the comments that need to be removed

In the future, maybe something more like "Remove duplicate 'the'
in two places."

But regardless, this looks fine to me.

Reviewed-by: Alex Elder <elder@...aro.org>

> 
> Signed-off-by: Jiang Jian <jiangjian@...rlc.com>
> ---
>   drivers/net/ipa/gsi_trans.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ipa/gsi_trans.c b/drivers/net/ipa/gsi_trans.c
> index cf646dc8e36a..29496ca15825 100644
> --- a/drivers/net/ipa/gsi_trans.c
> +++ b/drivers/net/ipa/gsi_trans.c
> @@ -339,7 +339,7 @@ struct gsi_trans *gsi_channel_trans_alloc(struct gsi *gsi, u32 channel_id,
>   	if (!gsi_trans_tre_reserve(trans_info, tre_count))
>   		return NULL;
>   
> -	/* Allocate and initialize non-zero fields in the the transaction */
> +	/* Allocate and initialize non-zero fields in the transaction */
>   	trans = gsi_trans_pool_alloc(&trans_info->pool, 1);
>   	trans->gsi = gsi;
>   	trans->channel_id = channel_id;
> @@ -669,7 +669,7 @@ int gsi_trans_read_byte(struct gsi *gsi, u32 channel_id, dma_addr_t addr)
>   	if (!gsi_trans_tre_reserve(trans_info, 1))
>   		return -EBUSY;
>   
> -	/* Now fill the the reserved TRE and tell the hardware */
> +	/* Now fill the reserved TRE and tell the hardware */
>   
>   	dest_tre = gsi_ring_virt(tre_ring, tre_ring->index);
>   	gsi_trans_tre_fill(dest_tre, addr, 1, true, false, IPA_CMD_NONE);