linux-kernel - Re: [PATCH 1/3] net: dsa: qca8k: reduce mgmt ethernet timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62b1da50.1c69fb81.c77ce.0278@mx.google.com>
Date:   Tue, 21 Jun 2022 16:48:47 +0200
From:   Christian Marangi <ansuelsmth@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jonathan McDowell <noodles@...th.li>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] net: dsa: qca8k: reduce mgmt ethernet timeout

On Tue, Jun 21, 2022 at 03:33:35PM +0300, Vladimir Oltean wrote:
> On Sat, Jun 18, 2022 at 08:22:58AM +0200, Christian Marangi wrote:
> > The current mgmt ethernet timeout is set to 100ms. This value is too
> > big and would slow down any mdio command in case the mgmt ethernet
> > packet have some problems on the receiving part.
> > Reduce it to just 5ms to handle case when some operation are done on the
> > master port that would cause the mgmt ethernet to not work temporarily.
> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > ---
> 
> I think this could very well qualify as a regression and have a tag of:
> 
> Fixes: 5950c7c0a68c ("net: dsa: qca8k: add support for mgmt read/write in Ethernet packet")
> 
> if it was presented along with a situation where users could hit some
> real life conditions where the Ethernet management interface isn't
> functional.
>

It's really to handle corner case... In testing the MTU change (and
noticing the mgmt ethernet going "macheroni") I notice the timeout was
absurdly high. In a situation where something goes wrong at least you
can have access to it after some time.

Ok I will add the fixes tag.

> >  drivers/net/dsa/qca8k.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/dsa/qca8k.h b/drivers/net/dsa/qca8k.h
> > index 04408e11402a..ec58d0e80a70 100644
> > --- a/drivers/net/dsa/qca8k.h
> > +++ b/drivers/net/dsa/qca8k.h
> > @@ -15,7 +15,7 @@
> >  
> >  #define QCA8K_ETHERNET_MDIO_PRIORITY			7
> >  #define QCA8K_ETHERNET_PHY_PRIORITY			6
> > -#define QCA8K_ETHERNET_TIMEOUT				100
> > +#define QCA8K_ETHERNET_TIMEOUT				5
> >  
> >  #define QCA8K_NUM_PORTS					7
> >  #define QCA8K_NUM_CPU_PORTS				2
> > -- 
> > 2.36.1
> > 

-- 
	Ansuel