linux-kernel - Re: [PATCH] mips: lantiq: falcon: Fix refcount leak bug in sysctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220621151533.GD12206@alpha.franken.de>
Date:   Tue, 21 Jun 2022 17:15:33 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Liang He <windhl@....com>
Cc:     john@...ozen.org, xkernel.wang@...mail.com, wangborong@...rlc.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: lantiq: falcon: Fix refcount leak bug in sysctrl

On Fri, Jun 17, 2022 at 08:19:58PM +0800, Liang He wrote:
> In ltq_soc_init(), of_find_compatible_node() will return a node pointer
> with refcount incremented. We should use of_node_put() when it is not
> used anymore.
> 
> Signed-off-by: Liang He <windhl@....com>
> ---
>  arch/mips/lantiq/falcon/sysctrl.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/mips/lantiq/falcon/sysctrl.c b/arch/mips/lantiq/falcon/sysctrl.c
> index 5204fc6d6d50..1187729d8cbb 100644
> --- a/arch/mips/lantiq/falcon/sysctrl.c
> +++ b/arch/mips/lantiq/falcon/sysctrl.c
> @@ -208,6 +208,12 @@ void __init ltq_soc_init(void)
>  			of_address_to_resource(np_sysgpe, 0, &res_sys[2]))
>  		panic("Failed to get core resources");
>  
> +	of_node_put(np_status);
> +	of_node_put(np_ebu);
> +	of_node_put(np_sys1);
> +	of_node_put(np_syseth);
> +	of_node_put(np_sysgpe);
> +
>  	if ((request_mem_region(res_status.start, resource_size(&res_status),
>  				res_status.name) < 0) ||
>  		(request_mem_region(res_ebu.start, resource_size(&res_ebu),
> -- 
> 2.25.1

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]