linux-kernel - Re: [PATCH -next] selinux: Cleanup the enum SEL_COMPAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhTXf=L97d9zuMOXr0JOm-vVgifJx7cSOJT+wLZZ7uA=gg@mail.gmail.com>
Date:   Tue, 21 Jun 2022 11:30:56 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Xiu Jianfeng <xiujianfeng@...wei.com>
Cc:     stephen.smalley.work@...il.com, eparis@...isplace.org,
        selinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] selinux: Cleanup the enum SEL_COMPAT_NET

On Tue, Jun 21, 2022 at 2:40 AM Xiu Jianfeng <xiujianfeng@...wei.com> wrote:
>
> The "compat_net" compatibility code has been removed since commit
> 58bfbb51ff2b ("selinux: Remove the "compat_net" compatibility code"),
> so SEL_COMPAT_NET need to be removed as well.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
> ---
>  security/selinux/selinuxfs.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
> index 8fcdd494af27..7115ca91ec05 100644
> --- a/security/selinux/selinuxfs.c
> +++ b/security/selinux/selinuxfs.c
> @@ -58,7 +58,6 @@ enum sel_inos {
>         SEL_DISABLE,    /* disable SELinux until next reboot */
>         SEL_MEMBER,     /* compute polyinstantiation membership decision */
>         SEL_CHECKREQPROT, /* check requested protection, not kernel-applied one */
> -       SEL_COMPAT_NET, /* whether to use old compat network packet controls */
>         SEL_REJECT_UNKNOWN, /* export unknown reject handling to userspace */
>         SEL_DENY_UNKNOWN, /* export unknown deny handling to userspace */
>         SEL_STATUS,     /* export current status using mmap() */

Thanks for the patch, but keeping the old enum value is harmless
considering the size of sel_inos and I would rather see it preserved
just on the odd chance that some userspace tool is relying on specific
inode values.

-- 
paul-moore.com