linux-kernel - Re: [PATCH 1/2] iio: adc: stm32-adc: make safe adc disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b43b142-e62c-d46b-8b42-449720682463@foss.st.com>
Date:   Tue, 21 Jun 2022 17:38:52 +0200
From:   Fabrice Gasnier <fabrice.gasnier@...s.st.com>
To:     Olivier Moysan <olivier.moysan@...s.st.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Wan Jiabing <wanjiabing@...o.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH 1/2] iio: adc: stm32-adc: make safe adc disable

On 6/20/22 17:47, Olivier Moysan wrote:
> From ADC reference manual the software is allowed to write the
> control bit ADDIS of the ADC_CR register only if the ADC is enabled.
> Return immediately from stm32h7_adc_disable() if ADC is already disabled.
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@...s.st.com>

Hi Olivier,

You can add my:
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@...s.st.com>

Thanks,
Fabrice

> ---
>  drivers/iio/adc/stm32-adc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
> index a68ecbda6480..80e333f65ddd 100644
> --- a/drivers/iio/adc/stm32-adc.c
> +++ b/drivers/iio/adc/stm32-adc.c
> @@ -876,6 +876,9 @@ static void stm32h7_adc_disable(struct iio_dev *indio_dev)
>  	int ret;
>  	u32 val;
>  
> +	if (!(stm32_adc_readl(adc, STM32H7_ADC_CR) & STM32H7_ADEN))
> +		return;
> +
>  	/* Disable ADC and wait until it's effectively disabled */
>  	stm32_adc_set_bits(adc, STM32H7_ADC_CR, STM32H7_ADDIS);
>  	ret = stm32_adc_readl_poll_timeout(STM32H7_ADC_CR, val,