linux-kernel - Re: [PATCH] scsi: sg: Fix typo in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4355e287-11e3-dfb2-f35e-5c991c57b85a@acm.org>
Date:   Wed, 22 Jun 2022 09:04:46 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Jiang Jian <jiangjian@...rlc.com>, dgilbert@...erlog.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: sg: Fix typo in comments

On 6/22/22 08:30, Jiang Jian wrote:
> there is an unexpected word 'is' in the comments that need to be dropped
> 
> file: drivers/scsi/sg.c
> line: 697
> 
> * but is is possible that the app intended SG_DXFER_TO_DEV, because there
> 
> changed to:
> 
> * but is possible that the app intended SG_DXFER_TO_DEV, because there
> 
> Signed-off-by: Jiang Jian <jiangjian@...rlc.com>
> ---
>   drivers/scsi/sg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index 118c7b4a8af2..047761f62b23 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -694,7 +694,7 @@ sg_write(struct file *filp, const char __user *buf, size_t count, loff_t * ppos)
>   	}
>   	/*
>   	 * SG_DXFER_TO_FROM_DEV is functionally equivalent to SG_DXFER_FROM_DEV,
> -	 * but is is possible that the app intended SG_DXFER_TO_DEV, because there
> +	 * but is possible that the app intended SG_DXFER_TO_DEV, because there
>   	 * is a non-zero input_size, so emit a warning.
>   	 */
>   	if (hp->dxfer_direction == SG_DXFER_TO_FROM_DEV) {

I do not agree with this change since the author of that comment 
probably wanted to write "[...] but it is possible [...]"

Bart.