linux-kernel - Re: [PATCH v3 3/3] scsi: ufs: ufshcd: constify pointed data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08544601-3364-0352-415f-2e3576b84976@acm.org>
Date:   Wed, 22 Jun 2022 09:13:35 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Doug Gilbert <dgilbert@...erlog.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-ide@...r.kernel.org
Subject: Re: [PATCH v3 3/3] scsi: ufs: ufshcd: constify pointed data

On 6/13/22 03:06, Krzysztof Kozlowski wrote:
> Constify arrays and pointers to data which is not modified for code
                                              ^^
> safety.

is -> are?

> @@ -7848,7 +7850,7 @@ static int ufshcd_quirk_tune_host_pa_tactivate(struct ufs_hba *hba)
>   	u32 granularity, peer_granularity;
>   	u32 pa_tactivate, peer_pa_tactivate;
>   	u32 pa_tactivate_us, peer_pa_tactivate_us;
> -	u8 gran_to_us_table[] = {1, 4, 8, 16, 32, 100};
> +	const u8 gran_to_us_table[] = {1, 4, 8, 16, 32, 100};

Can this array be declared static? Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>